-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove default maven central registry #13950
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Feb 1, 2022
rarkins
approved these changes
Feb 5, 2022
viceice
approved these changes
Feb 5, 2022
🎉 This PR is included in version 31.66.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Removes that the maven central url is added by default to all maven dependencies.
Context:
Closes #13925
According to the maven repository page this is a valid approach.
To me this means that if a repository is defined, it will take the place of the default.
In the test we have a simple pom which declares a repository, which will result in the maven repository not being added to the dependency.
However this could be a breaking change for repos that do not follow this approach but instead use maven central as default and add repositories on top of that.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: