-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(maven): settings.xml registry extraction #13592
Conversation
|
Needs test / coverage fixes |
Any suggestion on how to test the line? The Easy way out would be to annotate it. Edit: I have added the annotation for now, let me know if you want this changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look good to me. 😄
@viceice also ready for your final approval/merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two all questions left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
🎉 This PR is included in version 31.37.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Introduces registry url extraction for maven for
settings.xml
When a
settings.xml
resides in the repository under.mvn/settings.xml
,.m2/settings.xml
orsettings.xml
then we try to parse the file and extract registry urls from the<mirrors>
and<repositories>
child elements.This is then added to the registry urls Renovate uses to look up the maven packages.
Advantage: This frees the repository owner from adding all maven registries manually to the
renovate.json
.Instead they can rely on Renovate extracting them from the
settings.xml
if available.Todo:
Context:
Closes #13448
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: