Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform/azure): handle disabled repos without exit #13225

Merged
merged 2 commits into from
Dec 22, 2021
Merged

feat(platform/azure): handle disabled repos without exit #13225

merged 2 commits into from
Dec 22, 2021

Conversation

olegkrivtsov
Copy link
Contributor

Changes:

Renovate exit with code 0 when a Azure repository is disabled #13013

Context:

Closes #13013

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins December 22, 2021 05:55
@rarkins rarkins enabled auto-merge (squash) December 22, 2021 05:59
@rarkins rarkins merged commit 7d60807 into renovatebot:main Dec 22, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.11.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HonkingGoose
Copy link
Collaborator

This change is not shown in the actual release notes for 31.11.5.

The change got merged with a proper "Conventional Commits" PR title: feat(platform/azure): handle disabled repos without exit.
But the commit message on the main branch is: Fix issue (#13225): 7d60807

@viceice
Copy link
Member

viceice commented Dec 22, 2021

fixed

@HonkingGoose
Copy link
Collaborator

@viceice I see that you added this change to the "Bug Fixes" section in the release notes, but I think this is a feat: type commit, so it should go under a "Features" section in the release notes? Or is this actually more of a "bugfix" change?

Maybe you should change it so that its under it own Feature section, like in this changelog: https://github.com/renovatebot/renovate/releases/tag/31.11.0

@viceice
Copy link
Member

viceice commented Dec 22, 2021

i think a bugfix is ok for that small change 🤗

zanitete pushed a commit to nagra-insight/renovate that referenced this pull request Jan 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renovate exit with code 0 when a Azure repository is disabled
5 participants