feat(config)!: parse JSON5/YAML self-hosted admin config

docs/development/configuration.md

@@ -20,6 +20,9 @@ Options which have `"globalOnly": true` are reserved only for bot global configu
 You can override default configuration using a configuration file, with default name `config.js` in the working directory.
 If you need an alternate location or name, set it in the environment variable `RENOVATE_CONFIG_FILE`.
 
+**Note:** `RENOVATE_CONFIG_FILE` must be provided with an explicit file extension.
+If none is provided, or the file type is invalid, Renovate will fail.
+
 Using a configuration file gives you very granular configuration options.
 For instance, you can override most settings at the global (file), repository, or package level.
 e.g. apply one set of labels for `backend/package.json` and a different set of labels for `frontend/package.json` in the same repository.

lib/workers/global/config/parse/file.spec.ts

@@ -17,14 +17,7 @@ describe('workers/global/config/parse/file', () => {
   });
 
   describe('.getConfig()', () => {
-    it('raises deprecation warning when no extension given', async () => {
-      const configFile = upath.resolve(__dirname, './__fixtures__/file');
-      await file.getConfig({ RENOVATE_CONFIG_FILE: configFile });
-      expect(logger.info).toHaveBeenCalledWith(file.fileDeprecationMessage);
-    });
-
     it.each([
-      ['custom config file without extension', 'file'],
       ['custom config file with extension', 'file.js'],
       ['JSON5 config file', 'config.json5'],
       ['YAML config file', 'config.yaml'],
@@ -88,17 +81,19 @@ describe('workers/global/config/parse/file', () => {
 
       expect(mockProcessExit).toHaveBeenCalledWith(1);
     });
-    it('fatal error and exit if invalid config file type', async () => {
+
+    it.each([
+      ['invalid config file type', './file.txt'],
+      ['missing config file type', './file'],
+    ])('fatal error and exit if %s', async (fileType, filePath) => {
       const mockProcessExit = jest
         .spyOn(process, 'exit')
         .mockImplementation(() => undefined as never);
-      const configFile = upath.resolve(tmp.path, './file.txt');
+      const configFile = upath.resolve(tmp.path, filePath);
       fs.writeFileSync(configFile, `{"token": "abc"}`, { encoding: 'utf8' });
       await file.getConfig({ RENOVATE_CONFIG_FILE: configFile });
       expect(mockProcessExit).toHaveBeenCalledWith(1);
-      expect(logger.fatal).toHaveBeenCalledWith(
-        `Unsupported file type: ${configFile}`
-      );
+      expect(logger.fatal).toHaveBeenCalledWith('Unsupported file type');
       mockProcessExit.mockRestore();
       fs.unlinkSync(configFile);
     });

lib/workers/global/config/parse/file.ts

@@ -1,14 +1,11 @@
-import fs, { readFile } from 'fs-extra';
+import { readFile } from 'fs-extra';
 import { load } from 'js-yaml';
 import JSON5 from 'json5';
 import upath from 'upath';
 import { migrateConfig } from '../../../../config/migration';
 import type { AllConfig, RenovateConfig } from '../../../../config/types';
 import { logger } from '../../../../logger';
 
-export const fileDeprecationMessage =
-  'Providing a config file without an extension is deprecated. Please use explicit file extensions.';
-
 export async function getParsedContent(file: string): Promise<RenovateConfig> {
   switch (upath.extname(file)) {
     case '.yaml':
@@ -24,7 +21,7 @@ export async function getParsedContent(file: string): Promise<RenovateConfig> {
       return tmpConfig.default ? tmpConfig.default : tmpConfig;
     }
     default:
-      throw new Error(`Unsupported file type: ${file}`);
+      throw new Error('Unsupported file type');
   }
 }
 
@@ -33,16 +30,6 @@ export async function getConfig(env: NodeJS.ProcessEnv): Promise<AllConfig> {
   if (!upath.isAbsolute(configFile)) {
     configFile = `${process.cwd()}/${configFile}`;
   }
-  if (!upath.extname(configFile)) {
-    logger.info(fileDeprecationMessage);
-    for (const ext of ['.js', '.json']) {
-      const resolved = upath.addExt(configFile, ext);
-      if (await fs.exists(resolved)) {
-        configFile = resolved;
-        break;
-      }
-    }
-  }
   logger.debug('Checking for config file in ' + configFile);
   let config: AllConfig = {};
   try {
@@ -52,7 +39,7 @@ export async function getConfig(env: NodeJS.ProcessEnv): Promise<AllConfig> {
     if (err instanceof SyntaxError || err instanceof TypeError) {
       logger.fatal(`Could not parse config file \n ${err.stack}`);
       process.exit(1);
-    } else if (err.message.startsWith(`Unsupported file type`)) {
+    } else if (err.message === 'Unsupported file type') {
       logger.fatal(err.message);
       process.exit(1);
     } else if (env.RENOVATE_CONFIG_FILE) {