Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager): optimize lockfile cache handling #10463

Merged
merged 6 commits into from
Jun 16, 2021

Conversation

viceice
Copy link
Member

@viceice viceice commented Jun 16, 2021

Changes:

  • Use admin cacheDir
  • Add ./others/terrafrom to cache path
  • Create temp dir as admin cacheDir

Context:

failed tests on main branch because of missing cacheDir

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins June 16, 2021 13:15
@rarkins rarkins enabled auto-merge (squash) June 16, 2021 13:52
@rarkins rarkins merged commit 713e35e into main Jun 16, 2021
@rarkins rarkins deleted the fix/terraform-lockfile-cache branch June 16, 2021 14:19
rarkins added a commit that referenced this pull request Jun 16, 2021
viceice pushed a commit that referenced this pull request Jun 16, 2021
* fix: Revert "fix(manager): optimize lockfile cache handling (#10463)"

This reverts commit 713e35e.

* fix: Revert "fix(terraform): use path joins instead of slashes (#10461)"

This reverts commit 2776db6.

* fix: Revert "feat(terraform): update terraform lock files (#8429)"

This reverts commit dab27f2.
@viceice viceice mentioned this pull request Jun 16, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.43.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

secustor pushed a commit to secustor/renovate that referenced this pull request Jun 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants