ci: Clarify checkbox for modified unit tests #10447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeganwitt
changed the title
keeganwitt
changed the title
rarkins
approved these changes
Jun 15, 2021
|
On a related note, I've learned that PRs that only add unit tests are much easier to review than if you modify or both add and modify or only modify. When tests are modified along with code, you need to make sure that the test wasn't broken to match the broken code. But when they're only added.. it means you know the added code is backwards compatible with existing tests. |
|
🎉 This PR is included in version 25.42.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified some existing unit tests and wasn't sure what checkbox in the template was appropriate since none of them mentioned that. I also added the word "unit" to one of the checkboxes so that type of test is referred to by a consistent phrase in all checkboxes.