Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): Support for Bearer token to access the Docker registry #10400

Merged
merged 33 commits into from
Jun 16, 2021

Conversation

nielsbasjes
Copy link
Contributor

@nielsbasjes nielsbasjes commented Jun 11, 2021

Changes:

This is my first attempt to implement my suggestion as described here #10317

Essentially this allows using something like this to access a docker registry:

"hostRules": [{
  "matchHost": "eu.gcr.io",
  "token": "myReallySecretToken"
}],

Please nitpick this because it is my first code in this specific language.

Context:

The bearer token is the only way I can access the Google Container Registry.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

NOTE: I wrote the documentation, but the way I documented this (using secrets in config.js) it does not seem to work as I thought it would.
See also my question about this: #10399

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@nielsbasjes nielsbasjes changed the title Support for Bearer token to access the Docker registry feat(docker): Support for Bearer token to access the Docker registry Jun 11, 2021
docs/usage/docker.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small fixes to start with.

docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
lib/datasource/docker/common.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some more changes we could make to tidy up the text some more.

By the way, if you want to apply multiple suggestions from a pull request review, go to the "Files changed" tab on GitHub where you can "batch multiple suggestions" into one commit.
That should take less clicks than from the "conversation tab".

docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Show resolved Hide resolved
lib/config/presets/internal/packages.ts Outdated Show resolved Hide resolved
@nielsbasjes nielsbasjes marked this pull request as ready for review June 12, 2021 18:32
@nielsbasjes
Copy link
Contributor Author

Works on my machine:
image

docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
nielsbasjes and others added 3 commits June 12, 2021 22:39
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
@HonkingGoose HonkingGoose requested review from viceice and rarkins June 13, 2021 06:49
@viceice
Copy link
Member

viceice commented Jun 16, 2021

@nielsbasjes PLease use those buttons to rerequest a review, so i get notified when you're done.
image

@HonkingGoose HonkingGoose requested a review from viceice June 16, 2021 08:51
@nielsbasjes nielsbasjes requested a review from HonkingGoose June 16, 2021 08:56
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation is nearly good to go, some things we can improve on some more.

docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
docs/usage/docker.md Outdated Show resolved Hide resolved
viceice
viceice previously approved these changes Jun 16, 2021
Co-authored-by: HonkingGoose <[email protected]>
@nielsbasjes nielsbasjes dismissed stale reviews from viceice via a8c76d1 June 16, 2021 11:48
HonkingGoose
HonkingGoose previously approved these changes Jun 16, 2021
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs look good to me now!

viceice
viceice previously approved these changes Jun 16, 2021
@viceice viceice dismissed stale reviews from HonkingGoose and themself via cd3ef36 June 16, 2021 14:23
@rarkins rarkins enabled auto-merge (squash) June 16, 2021 20:14
@rarkins rarkins merged commit d4a22c7 into renovatebot:main Jun 16, 2021
@HonkingGoose
Copy link
Collaborator

Congratulations @nielsbasjes on getting this PR landed! 🚀

Well done everybody with the review comments/suggestions to clean this up! 😄

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.44.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants