-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): Support for Bearer token to access the Docker registry #10400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small fixes to start with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some more changes we could make to tidy up the text some more.
By the way, if you want to apply multiple suggestions from a pull request review, go to the "Files changed" tab on GitHub where you can "batch multiple suggestions" into one commit.
That should take less clicks than from the "conversation tab".
Co-authored-by: Michael Kriese <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
09947cc
to
0997200
Compare
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
@nielsbasjes PLease use those buttons to rerequest a review, so i get notified when you're done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation is nearly good to go, some things we can improve on some more.
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs look good to me now!
Congratulations @nielsbasjes on getting this PR landed! 🚀 Well done everybody with the review comments/suggestions to clean this up! 😄 |
🎉 This PR is included in version 25.44.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
This is my first attempt to implement my suggestion as described here #10317
Essentially this allows using something like this to access a docker registry:
Please nitpick this because it is my first code in this specific language.
Context:
The bearer token is the only way I can access the Google Container Registry.
Documentation (please check one with an [x])
NOTE: I wrote the documentation, but the way I documented this (using secrets in config.js) it does not seem to work as I thought it would.
See also my question about this: #10399
How I've tested my work (please tick one)
I have verified these changes via: