Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set { dot: true } for postUpgradeTasks.fileFilters #21276

Closed
rarkins opened this issue Apr 1, 2023 · 1 comment · Fixed by #21282
Closed

Set { dot: true } for postUpgradeTasks.fileFilters #21276

rarkins opened this issue Apr 1, 2023 · 1 comment · Fixed by #21282
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality) v36

Comments

@rarkins
Copy link
Collaborator

rarkins commented Apr 1, 2023

What would you like Renovate to be able to do?

From #21220: default to including dot files for fileFilters in postUpgradeTasks

If you have any ideas on how this should be implemented, please tell us here.

Set { dot: true } when calling minimatch

Is this a feature you are interested in implementing yourself?

No
@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others breaking Breaking change, requires major version bump status:ready labels Apr 1, 2023
bgutschke added a commit to bgutschke/renovate that referenced this issue Apr 1, 2023
@bgutschke
fix(post-upgrade-tasks)!: enable dot option for file filters (renovat…
341198d 
…ebot#21276)

Default to including dot files for fileFilters in postUpgradeTasks

Closes renovatebot#21276

BREAKING CHANGE: Glob patterns used for Post upgrade task "fileFilters" now include
dotfiles by default.
bgutschke added a commit to bgutschke/renovate that referenced this issue Apr 1, 2023
@bgutschke
fix(post-upgrade-tasks)!: enable dot option for file filters (renovat…
54d2d85 
…ebot#21276)

Default to including dot files for fileFilters in postUpgradeTasks

Closes renovatebot#21276

BREAKING CHANGE: Glob patterns used for Post upgrade task "fileFilters" now include
dotfiles by default.
@bgutschke bgutschke mentioned this issue Apr 1, 2023
Merged
6 tasks
@rarkins rarkins added the v36 label Jun 12, 2023
rarkins pushed a commit that referenced this issue Jul 4, 2023
@bgutschke @rarkins
fix(post-upgrade-tasks)!: enable dot option for file filters (#21282)
4d7b4fe 
Set `{ dot: true }` for minimatch.

Closes #21276

BREAKING CHANGE: dot files will now be included by default for all minimatch results
@rarkins rarkins closed this as completed in bc693f2 Jul 4, 2023
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 36.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot mentioned this issue Jul 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality) v36
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(post-upgrade-tasks)!: enable dot option for file filters bgutschke/renovate
2 participants
@rarkins @renovate-release