Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node-sass and sass-loader not loaded #164

Merged
merged 3 commits into from
Dec 20, 2019
Merged

Fix node-sass and sass-loader not loaded #164

merged 3 commits into from
Dec 20, 2019

Conversation

tim-kilian
Copy link
Member

Closes #63

Changes

  • Move node-sass and sass-loader to app dependencies
  • Update node-sass and sass-loader to newest version

@tim-kilian tim-kilian requested review from 0x4d and AnupKM December 10, 2019 14:27
@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #164 into master will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   62.17%   62.46%   +0.29%     
==========================================
  Files         154      154              
  Lines        1922     2025     +103     
==========================================
+ Hits         1195     1265      +70     
- Misses        727      760      +33
Impacted Files Coverage Δ
src/util/Geometry.js 36.36% <0%> (-1.38%) ⬇️
src/core/toolbox/providers/Toolbox.js 79.88% <0%> (+0.51%) ⬆️
src/core/Canvas.js 71.42% <0%> (+1.42%) ⬆️
...c/features/create/behaviors/CreateLabelBehavior.js 66.66% <0%> (+1.44%) ⬆️
src/features/move/commands/MoveElementsCommand.js 50% <0%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b06ee6d...1a6546b. Read the comment docs.

@tim-kilian
Copy link
Member Author

Removed unwanted commited changes

@0x4d 0x4d merged commit 1d3cdb7 into master Dec 20, 2019
@tim-kilian tim-kilian deleted the #163-sass-loader branch December 20, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom jasmine eslint for test directory
2 participants