Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection labels #155

Merged
merged 3 commits into from
Aug 20, 2019
Merged

Add connection labels #155

merged 3 commits into from
Aug 20, 2019

Conversation

0x4d
Copy link
Contributor

@0x4d 0x4d commented Aug 18, 2019

Closes #150

Describe your changes

  • Calculate connection label position after import (needs renew-formalism-pt#24)
  • Calculate connection label position in CreateLabelBehavior

@0x4d 0x4d requested a review from tim-kilian August 18, 2019 16:23
@codecov
Copy link

codecov bot commented Aug 18, 2019

Codecov Report

Merging #155 into master will decrease coverage by 0.22%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   63.16%   62.93%   -0.23%     
==========================================
  Files         154      154              
  Lines        1876     1886      +10     
==========================================
+ Hits         1185     1187       +2     
- Misses        691      699       +8
Impacted Files Coverage Δ
src/features/import/providers/Importer.js 68.75% <0%> (-9.83%) ⬇️
src/core/Canvas.js 77.77% <0%> (-2.23%) ⬇️
...c/features/create/behaviors/CreateLabelBehavior.js 68.18% <40%> (-8.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc1c97...baec150. Read the comment docs.

@0x4d 0x4d changed the title WIP: Add connection labels Add connection labels Aug 18, 2019
Copy link
Member

@tim-kilian tim-kilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please generalize BBox method before merge.

@0x4d
Copy link
Contributor Author

0x4d commented Aug 19, 2019

Please generalize BBox method before merge.

Will refactor the method signature tonight

@tim-kilian tim-kilian merged commit cc28065 into master Aug 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the arc-inscriptions branch August 20, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labels for connections
2 participants