Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task-driver: integration: Update integration tests with fees changes #450

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

joeykraut
Copy link
Member

Purpose

This PR fixes up the integration tests for the task driver given the fees changes.

I'm dealing with a serialization bug related to serde-rs/serde#1682 so the tests do not currently pass. Will fix them up in the next follow up.

Testing

  • Unit tests pass

@@ -362,110 +369,29 @@ integration_test_async!(test_update_wallet__remove_fee);
// | Balances |
// ------------

/// Tests updating a wallet by depositing into the pool
#[allow(non_snake_case)]
async fn test_update_wallet__deposit_and_withdraw(test_args: IntegrationTestArgs) -> Result<()> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate

@joeykraut joeykraut force-pushed the joey/task-driver-tests branch from 697334d to 8a16d21 Compare March 1, 2024 19:17
@joeykraut joeykraut requested a review from akirillo March 1, 2024 19:17
@joeykraut joeykraut marked this pull request as ready for review March 1, 2024 19:17
Copy link
Contributor

@akirillo akirillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one necessary change, but doesn't require discussion so approving. you made the code i wrote much cleaner lol

@joeykraut joeykraut merged commit 19013f8 into joey/fees-circuits Mar 1, 2024
1 of 3 checks passed
@joeykraut joeykraut deleted the joey/task-driver-tests branch March 1, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants