Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'async' module with just the 'async.parallel' functionality #36

Open
spikebrehm opened this issue May 8, 2013 · 4 comments
Open

Comments

@spikebrehm
Copy link
Member

We include the entire async module, and require it in the client, just to use async.parallel in fetcher:

https://github.com/airbnb/rendr/blob/master/shared/fetcher.js#L185

Find/write a tiny module that just provides the parallel method.

@alexindigo
Copy link
Member

Btw, is there reason for using old version of async (0.1.22 vs 0.2.9)?

@spikebrehm
Copy link
Member Author

Nope, no reason. It doesn't actually look like 0.2.x has breaking changes;
just new methods:

https://twitter.com/indexzero/status/419285490844450816

On Friday, January 3, 2014, Alex Indigo wrote:

Btw, is there reason for using old version of async (`0.1.22' vs '0.2.9')?


Reply to this email directly or view it on GitHubhttps://github.com//issues/36#issuecomment-31560539
.

Spike Brehm
Software Engineer
www.airbnb.com

San Francisco, CA, USA
C: (602) 828-2358
See how Airbnb works https://www.airbnb.com/info/how_it_works

@alexindigo
Copy link
Member

I see, thanx.

@rcs
Copy link
Contributor

rcs commented Jan 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants