Made it play nice with RequireJS powered setup. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| modelUtils = modelUtils || require('rendr/shared/modelUtils'); | ||
| // Another lazy-loading attempt | ||
| var lazyRequire_baseView = 'rendr/shared/base/view'; | ||
| var lazyRequire_modelUtils = 'rendr/shared/modelUtils'; |
There was a problem hiding this comment.
Curious, this doesn't break the Require.js stuff? It needs these modules -- or is it okay, because they're already bundled by other modules that require them?
|
LGTM 👍 |
Conflicts: index.js server/layoutFinder.js shared/helpers.js shared/templateFinder.js test/shared/templateFinder.test.js
|
@spikebrehm I merged in changes from the current master, so it would work with latest rendr. |
spikebrehm
pushed a commit
that referenced
this pull request
Dec 4, 2013
Made it play nice with RequireJS powered setup.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2 on RequreJs support,
this time with smaller set of changes.
Related to rendrjs/rendr#173
/cc @jskulski