Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webpacker as a dependency #146

Closed

Conversation

rossta
Copy link

@rossta rossta commented Sep 13, 2022

Fixes #145

This PR removes webpacker as a Ruby dependency to prevent conflicts in apps that are moving from Webpacker to Shakapacker.

Changes:

Please ensure that:

  • Changelog is updated if not a minor patch
  • Ruby linting is ok: rubocop is all green
  • Javascript linting is ok: cd javascript/webpacker_react-npm-module/ && yarn lint is all green
  • Tests are all green

@rossta
Copy link
Author

rossta commented Sep 13, 2022

I'm now seeing some work to rewrite the project in a non-Webpacker form https://github.com/renchap/webpacker-react/compare/react-components-rails. Let me know if you could use help moving the react-component-rails work forward.

I could see some value in releasing this change as an intermediate step as I currently need to work off my own fork.

@rossta rossta force-pushed the feature/remove-webpacker-dependency branch 5 times, most recently from 0f60751 to 2815c78 Compare September 13, 2022 15:35
Update bundler and other development dependencies

Upgrade webpacker development dependency

Update rubocop rules

Add Sprockets 4 manifest

Update rails, capybara, webdriver dependencies

Updates js error inspection to match more recent Selenium Webdriver API
Also add support for running build against multiple versions of Ruby,
starting with Ruby 3.0 and 3.1

Adds CircleCI orbs to support Ruby gem, NPM package, and browser
installation
@rossta rossta force-pushed the feature/remove-webpacker-dependency branch from 2815c78 to a319fdf Compare September 13, 2022 15:43
@rossta
Copy link
Author

rossta commented Sep 13, 2022

I've also done some work to upgrade development dependencies and the CircleCI config to get tests passing.

@renchap
Copy link
Owner

renchap commented Sep 15, 2022

Hi @rossta and thanks for your PR.

As you saw in #139, I plan to rename this gem to react-components-rails soon after a full rewrite. It no longers depend on Webpacker (or any Rails JS integration) and only contains light helpers to use React components in rails.

A beta version is release (and I have been using it in my projects) and I would encourage you to try it and tell me if it works for you. I am a bit overwhelmed with other work lately, but I still plan to make the big move in the coming weeks and deprecate webpacker-rails (with a message on gem install saying so on the linked PR).

I do not really want to make any change to the current webpacker-rails gem, so I will not merge your PR, as I think react-components-rails will give you what you want with far less code and dependencies.

@renchap renchap closed this Sep 15, 2022
@rossta rossta mentioned this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Shakapacker
2 participants