This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Add extraction user sound from previous_version/sound to game_dir/sound #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukhymenko-yurii
changed the title
|
In addition I fixed problem when extraction from previous_version more then one soundpack was interrupted in post_extraction_step3 |
|
I should be able to review and test this soon. |
|
copy_next_soundpack runs as callback of ProgressCopyTree so post_extraction_step3 executing and set in_post_extraction to False before all done |
|
Oh, i was wrong. Its was my issue. I revert my changes and move calling post_extraction_step3 to the right place. Sorry. |
remyroy
reviewed
Dec 9, 2020
| ] | ||
| for soundpacks_dir in soundpacks_dirs: | ||
| if os.path.isdir(soundpacks_dir): | ||
| self.soundpacks_dir = soundpacks_dir |
There was a problem hiding this comment.
self.soundpacks_dir should probably always remains in os.path.join(new_dir, 'data', 'sound'). It is used in move_new_soundpack for instance. With your code, it will be changed to os.path.join(new_dir, 'sound') after the loop.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After update game, user sound (game_dir/sound), not been extracted from previous_version/sound.