Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Nodemon.json file support #183

Closed
wants to merge 6 commits into from
Closed

Added Nodemon.json file support #183

wants to merge 6 commits into from

Conversation

pasindud
Copy link
Contributor

@pasindud pasindud commented Jun 9, 2013

Currently nodemon.json supports ignore and it also supports for previous .nodemonignore

@@ -18,6 +18,7 @@ var fs = require('fs'),
ignoreFilePath = './.nodemonignore',
ignoreFileWatcher = null,
oldIgnoreFilePath = './nodemon-ignore',
NodejsonFilePath = './nodemon.json',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camelCase pls.

@remy
Copy link
Owner

remy commented Jun 9, 2013

I'll review this code, but the addition of a json file won't just be for ignoring files, it'll also add config for watch extensions and directories to watch - which is why I don't want to just pull this in quickly.

@pasindud
Copy link
Contributor Author

pasindud commented Jun 9, 2013

Yeap sure i just thought this would be good to get things started

@pasindud pasindud mentioned this pull request Jul 21, 2013
@remy
Copy link
Owner

remy commented Aug 1, 2013

Just to give you an update, this pull request has sparked a rewrite of nodemon here: https://github.com/remy/nodemon/tree/feature/json-config - it's a work in progress, very early days, but a good thing! But, also quite a long way to go...

I'm going to close this pull request as the json support is going to land and be the default way to deal with nodemon.

Thanks so much for the pull—I'll be raising a pull request for the new branch with lots of TODOs if you want to help out dev or test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants