Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we scan every type for variants during Jib monomorphisation #363

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

Alasdair
Copy link
Collaborator

This might be quite a bit more expensive than what we were doing previously but is needed to avoid missing any type that is used within a function but never appears in any external type signature or is never constructed.

This might be quite a bit more expensive than what we were doing
previously but is needed to avoid missing any type that is used within a
function but never appears in any external type signature or is never
constructed
Copy link

github-actions bot commented Oct 31, 2023

Test Results

       8 files  ±0       19 suites  ±0   0s ⏱️ ±0s
   551 tests +1     551 ✔️ +1  0 💤 ±0  0 ±0 
1 840 runs  +6  1 839 ✔️ +6  1 💤 ±0  0 ±0 

Results for commit 11845f7. ± Comparison against base commit 4437a67.

♻️ This comment has been updated with latest results.

@Alasdair Alasdair merged commit 83c2900 into sail2 Oct 31, 2023
9 checks passed
@Alasdair Alasdair deleted the fix_unconstructed_type branch November 13, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant