remotion: new onVideoFrame callback allowing an OffthreadVideo to be drawn to a canvas
#4147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
khanzzirfan
reviewed
Aug 2, 2024
| <OffthreadVideo | ||
| onVideoFrame={onVideoFrame} | ||
| style={{opacity: 0}} | ||
| startFrom={300} |
There was a problem hiding this comment.
This works nicely if startFrom > 0. Consider a situation when startFrom=0 and there are multiple sequences and generating video using Lambda.
if startFrom=0, generally canvas sync will show blankscreen, since the video is not started. To remediate we have to offset 0th second to 0.1 frame to show the initial start screen to sync with canvas and avoid having the empty screen.
There was a problem hiding this comment.
@khanzzirfan It has nothing to do with startFrom, it works with any value.
I only put 300 as value because the video starts with a black frame.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to draw OffthreadVideo to canvas: https://www.remotion.dev/docs/video-manipulation