Make tests platform-independent #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
=========================================
Coverage 89.37% 89.37%
Complexity 258 258
=========================================
Files 4 4
Lines 3483 3483
Branches 833 833
=========================================
Hits 3113 3113
Misses 176 176
Partials 194 194
Continue to review full report at Codecov.
|
|
Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had failing tests after cloning the repo on Windows. The reason was that the bash scripts in the test resources were checkout out using CRLF line endings.
The PR address this problem by enforcing platform-specific line endings where it matters via .gitattributes. A file extension is added to the bash scripts to make the .gitattributes file easier to maintain.