Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move old JLine 3 example to wiki #1117

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

thetoothpick
Copy link
Contributor

Update JLine 3 readme to only show most recent example, and link to old examples on the wiki.

fixes #1098.

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2020

Codecov Report

Merging #1117 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1117   +/-   ##
=========================================
  Coverage     94.36%   94.36%           
  Complexity      448      448           
=========================================
  Files             2        2           
  Lines          6633     6633           
  Branches       1782     1782           
=========================================
  Hits           6259     6259           
  Misses           99       99           
  Partials        275      275           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d4498...1092d2c. Read the comment docs.

@thetoothpick
Copy link
Contributor Author

In our codebase, I moved the picocli command object itself into a separate class, leaving only the JLine3 main method. Doing this here would clean up the example code and probably make it easier for someone else to incorporate into their project - thoughts @remkop ?

@remkop
Copy link
Owner

remkop commented Jun 22, 2020

Thank you!
Working on some other commitments now, I will take a detailed look soon.

@remkop remkop added this to the 4.4 milestone Jul 1, 2020
@remkop remkop merged commit 28a2de8 into remkop:master Jul 1, 2020
@remkop
Copy link
Owner

remkop commented Jul 1, 2020

Merged into master. (Sorry it took a while.)
Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

breaking changes in JLine 3.15.0
3 participants