Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion from root command #1056

Merged
merged 3 commits into from
May 19, 2020
Merged

Conversation

charphi
Copy link
Contributor

@charphi charphi commented May 19, 2020

Fix #1051

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #1056 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1056   +/-   ##
=========================================
  Coverage     94.35%   94.35%           
  Complexity      442      442           
=========================================
  Files             2        2           
  Lines          6483     6484    +1     
  Branches       1735     1736    +1     
=========================================
+ Hits           6117     6118    +1     
  Misses           94       94           
  Partials        272      272           
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/AutoComplete.java 97.04% <100.00%> (ø) 139.00 <0.00> (ø)
src/main/java/picocli/CommandLine.java 94.19% <100.00%> (+<0.01%) 303.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aee4f22...e1658d6. Read the comment docs.

Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I put some comments for minor improvements.

src/test/java/picocli/AutoCompleteTest.java Outdated Show resolved Hide resolved
src/test/java/picocli/AutoCompleteTest.java Outdated Show resolved Hide resolved
src/test/java/picocli/AutoCompleteTest.java Outdated Show resolved Hide resolved
src/main/java/picocli/AutoComplete.java Outdated Show resolved Hide resolved
Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the user manual to add the new ROOT-COMMAND-NAME to the variables section?

And any other documentation you can think of.

@charphi
Copy link
Contributor Author

charphi commented May 19, 2020

I've just modified index.adoc but I'm not sure what to do next since I'm not familiar with asciidoc.

@remkop remkop added this to the 4.4 milestone May 19, 2020
@remkop remkop added theme: auto-completion An issue or change related to auto-completion type: enhancement ✨ labels May 19, 2020
@remkop remkop merged commit dfbd00d into remkop:master May 19, 2020
@remkop
Copy link
Owner

remkop commented May 19, 2020

Merged into master.
Thank you for the contribution!

@charphi charphi deleted the feature-root-completion branch May 20, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: auto-completion An issue or change related to auto-completion type: enhancement ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GenerateCompletion command only works if used as direct subcommand of root
3 participants