-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add completion from root command #1056
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1056 +/- ##
=========================================
Coverage 94.35% 94.35%
Complexity 442 442
=========================================
Files 2 2
Lines 6483 6484 +1
Branches 1735 1736 +1
=========================================
+ Hits 6117 6118 +1
Misses 94 94
Partials 272 272
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. I put some comments for minor improvements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the user manual to add the new ROOT-COMMAND-NAME to the variables section?
And any other documentation you can think of.
I've just modified |
Merged into master. |
Fix #1051