remove socket listeners on “abort” (#29)

Co-authored-by: Matt Brophy <[email protected]>
remix-run · Aug 1, 2023 · 5d1e12a · 5d1e12a
1 parent 3e4d588
commit 5d1e12a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.changeset/grumpy-steaks-hug.md b/.changeset/grumpy-steaks-hug.md
@@ -0,0 +1,5 @@
+---
+"@remix-run/web-fetch": patch
+---
+
+Remove socket listeners if request is aborted
diff --git a/packages/fetch/src/fetch.js b/packages/fetch/src/fetch.js
@@ -364,10 +364,13 @@ function fixResponseChunkedTransferBadEnding(request, errorCallback) {
 		socket.prependListener('close', onSocketClose);
 		socket.on('data', onData);
 
-		request.on('close', () => {
+		const removeSocketListeners = () => {
 			socket.removeListener('close', onSocketClose);
 			socket.removeListener('data', onData);
-		});
+		}
+
+		request.on('close', removeSocketListeners);
+		request.on('abort', removeSocketListeners);
 	});
 }