Only add Remix packages to ssr.external
in Remix repo
#9301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by the changeset, this fixes an issue where consumers who had added Remix packages to Vite's
ssr.noExternal
option were being overridden by the Remix Vite plugin adding Remix packages to Vite'sssr.external
option.Our use of
ssr.noExternal
(fixing a Vite issue within the Remix repo) was incorrectly thought to be a no-op for consumers, so instead we now detect when we're in the Remix repo before applying the fix.