Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vite-ecosystem-ci integration #8997

Merged
merged 9 commits into from
Mar 8, 2024

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Mar 6, 2024

vite-ecosystem-ci is running against Remix now that we're on pnpm, but it's currently failing: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/8167613518/job/22328285298#step:8:996

I've reproduced it locally against this PR's branch to resolve this and all subsequent issues.

Copy link

changeset-bot bot commented Mar 6, 2024

⚠️ No Changeset found

Latest commit: 99b6c03

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markdalgleish markdalgleish marked this pull request as draft March 7, 2024 00:46
@markdalgleish markdalgleish changed the title Fix vite-ecosystem-ci clearTimeout type error Fix vite-ecosystem-ci integration Mar 7, 2024
@markdalgleish markdalgleish marked this pull request as ready for review March 8, 2024 02:56
@markdalgleish markdalgleish merged commit bfdcc66 into dev Mar 8, 2024
9 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/vite-ecosystem-type-fix branch March 8, 2024 03:09
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed vite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant