-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add vite setup to tailwind #8947
Conversation
Hi @hinryd, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I'm actually working on reworking these docs at the moment. With the move to Vite, we shouldn't need to document integrations like this anymore since the setup process isn't Remix specific. I'm closing this for now, but I'd love to hear your thoughts once we update the docs.
Hi @hinryd. Do you find that when you import as a side-effect ( If I set it up as follows though, then HMR works as expected: import tailwind from "~/tailwind.css?url";
export const links: LinksFunction = () => [
{ rel: "stylesheet", href: tailwind },
]; UPDATE: Found the issue. My bad... 🤦♂️ #7853 (comment) |
The original steps does not work as intended and will cause error.
Vite can natively resolve CSS file, so directly import it should suffice.