Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add vite setup to tailwind #8947

Closed
wants to merge 2 commits into from
Closed

Conversation

hinryd
Copy link

@hinryd hinryd commented Feb 29, 2024

The original steps does not work as intended and will cause error.
Vite can natively resolve CSS file, so directly import it should suffice.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 29, 2024

Hi @hinryd,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

Copy link

changeset-bot bot commented Feb 29, 2024

⚠️ No Changeset found

Latest commit: dd3ce9c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 29, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I'm actually working on reworking these docs at the moment. With the move to Vite, we shouldn't need to document integrations like this anymore since the setup process isn't Remix specific. I'm closing this for now, but I'd love to hear your thoughts once we update the docs.

@maxfi
Copy link

maxfi commented Mar 8, 2024

The original steps does not work as intended and will cause error. Vite can natively resolve CSS file, so directly import it should suffice.

Hi @hinryd. Do you find that when you import as a side-effect (import "./tailwind.css") that HMR doesn't reload the css when changes are made? What I'm seeing is that all tailwind styling is lost on the page after HMR, and a page reload is required...

If I set it up as follows though, then HMR works as expected:

import tailwind from "~/tailwind.css?url";

export const links: LinksFunction = () => [
  { rel: "stylesheet", href: tailwind },
];

UPDATE: Found the issue. My bad... 🤦‍♂️ #7853 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants