-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Vite critical CSS resolution when cwd differs from project root #8752
Conversation
🦋 Changeset detectedLatest commit: d316123 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this!
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Hi 👋
While integrating Remix<>Hydrogen in workerd, I found a weird issue with path resolution when applying critical CSS. Turns out it was resolving
app/entry.client.tsx
usingprocess.cwd()
(by omission) instead ofrootDirectory
, which can be different in some situations.