refactor(remix-dev/vite): clean resolved Remix config #8586
Conversation
|
markdalgleish
changed the title
packages/remix-dev/vite/plugin.ts
Outdated
| export let getServerBuildRootDirectory = (buildContext: BuildContext) => | ||
| getServerBuildDirectory(buildContext); |
There was a problem hiding this comment.
| export let getServerBuildRootDirectory = (buildContext: BuildContext) => | |
| getServerBuildDirectory(buildContext); | |
| export let getServerBuildRootDirectory = getServerBuildDirectory; |
Though at that point, might be worth just exporting getServerBuildDirectory directly
There was a problem hiding this comment.
Nice catch, I missed this!
| @@ -218,6 +211,13 @@ type BuildContext = | |||
| serverBundleId: string | undefined; | |||
There was a problem hiding this comment.
Is there a reason this is string | undefined instead of ?: string?
There was a problem hiding this comment.
So that you're forced to add the key to the object, even if the value is undefined.
markdalgleish
deleted the
markdalgleish/clean-resolved-vite-plugin-config
branch
github-actions
bot
added
the
awaiting release
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
github-actions
bot
removed
the
awaiting release
This is a follow-up to #8582, in preparation to expose the resolved Remix config as public API (e.g. via the adapter buildEnd hook).
The only remaining properties on the resolved
remixConfigobject that aren't present in the user-facing config type arerootDirectory,entryClientFilePathandentryServerFilePath. These have now been moved to thebuildContextobject. Since a lot of code assumes these are onremixConfig, it required a bit of a refactor to accomodate this.