-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(remix-dev/vite): resolve absolute serverBuildDirectory #8542
Conversation
|
let serverBuildConfig = serverBuildConfigByBundleId.get(bundleId); | ||
if (!serverBuildConfig) { | ||
serverBundlesManifest.serverBundles[bundleId] = { | ||
id: bundleId, | ||
file: normalizePath( | ||
path.join(serverBundleDirectory, serverBuildFile) | ||
path.join(relativeServerBundleDirectory, serverBuildFile) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is a case where we want it to be relative since it's a root-relative manifest file.
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
All paths on the resolved Remix config should be absolute but
serverBuildDirectory
was root-relative which made it awkward for any consuming code.Since we're now resolving options from the Vite plugin, I've refactored the code to make it clearer that we're only calling
resolveConfig
for options that are compatible with the Remix esbuild compiler.