Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(remix-dev/vite): resolve absolute serverBuildDirectory #8542

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

markdalgleish
Copy link
Member

All paths on the resolved Remix config should be absolute but serverBuildDirectory was root-relative which made it awkward for any consuming code.

Since we're now resolving options from the Vite plugin, I've refactored the code to make it clearer that we're only calling resolveConfig for options that are compatible with the Remix esbuild compiler.

Copy link

changeset-bot bot commented Jan 18, 2024

⚠️ No Changeset found

Latest commit: ffbb846

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

let serverBuildConfig = serverBuildConfigByBundleId.get(bundleId);
if (!serverBuildConfig) {
serverBundlesManifest.serverBundles[bundleId] = {
id: bundleId,
file: normalizePath(
path.join(serverBundleDirectory, serverBuildFile)
path.join(relativeServerBundleDirectory, serverBuildFile)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is a case where we want it to be relative since it's a root-relative manifest file.

@markdalgleish markdalgleish merged commit d26d2d8 into dev Jan 18, 2024
9 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/absolute-server-build-dir branch January 18, 2024 04:47
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jan 18, 2024
Copy link
Contributor

🤖 Hello there,

We just published version 2.5.1-pre.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.6.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Feb 1, 2024

🤖 Hello there,

We just published version 2.6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant