You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vite introduced server.watch: null in vitejs/vite#14208. Initial use case was for Vitest, but reading the thread there, it looks like Astro also had such use case.
I think disabling server.watch during dev might be also fine since currently child compiler doesn't make use of Vite's caching/invalidation so watcher might not be necessary as well. But for now, disabling for build seems obvious, so I only did that here.
testing
I cannot think of a way to verify the change exactly... Maybe better to ask the issue author to verify this by patching it locally.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
We just published version 2.4.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!
We just published version 2.4.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #8313
Vite introduced
server.watch: nullin vitejs/vite#14208. Initial use case was for Vitest, but reading the thread there, it looks like Astro also had such use case.I think disabling
server.watchduring dev might be also fine since currently child compiler doesn't make use of Vite's caching/invalidation so watcher might not be necessary as well. But for now, disabling for build seems obvious, so I only did that here.testing
I cannot think of a way to verify the change exactly... Maybe better to ask the issue author to verify this by patching it locally.