Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev/vite): support HMR for routes with handle export #8022

Merged
merged 7 commits into from
Nov 21, 2023

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Nov 16, 2023

(I didn't create a corresponding issue for this. If that's desired, I'll create one, so please let me know!)

I stumbled upon this issue when I was upgrading my remix app to vite (a bit too dirty example, but just for the reference hi-ogawa/ytsub-v3#519).
I also created a simpler reproduction here https://stackblitz.com/edit/remix-run-remix-gqubq9?file=app%2Froutes%2F_index.tsx

I wasn't sure if handle was intentionally left out from acceptExports whitelist, but when I tested by adding handle there, it looks working fine.
Please let me know if I missed something.

Copy link

changeset-bot bot commented Nov 16, 2023

🦋 Changeset detected

Latest commit: 43f9621

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hi-ogawa hi-ogawa marked this pull request as ready for review November 16, 2023 02:00
Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@markdalgleish markdalgleish merged commit e987fc3 into remix-run:dev Nov 21, 2023
9 checks passed
Copy link
Contributor

🤖 Hello there,

We just published version 2.3.1-pre.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@hi-ogawa hi-ogawa deleted the fix-vite-handle-export-hmr branch November 23, 2023 12:56
Copy link
Contributor

github-actions bot commented Dec 5, 2023

🤖 Hello there,

We just published version 2.4.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.4.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants