-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix-dev/vite): support HMR for routes with handle
export
#8022
fix(remix-dev/vite): support HMR for routes with handle
export
#8022
Conversation
🦋 Changeset detectedLatest commit: 43f9621 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
(I didn't create a corresponding issue for this. If that's desired, I'll create one, so please let me know!)
I stumbled upon this issue when I was upgrading my remix app to vite (a bit too dirty example, but just for the reference hi-ogawa/ytsub-v3#519).
I also created a simpler reproduction here https://stackblitz.com/edit/remix-run-remix-gqubq9?file=app%2Froutes%2F_index.tsx
I wasn't sure if
handle
was intentionally left out fromacceptExports
whitelist, but when I tested by addinghandle
there, it looks working fine.Please let me know if I missed something.