Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev/vite): skip "vanilla-extract" plugin in child compiler #7994

Conversation

hi-ogawa
Copy link
Contributor

Closes: #7989

This is less general approach of fixing the issue, but for the specific case of vanilla-extract, this could be a reasonable workaround.
My assumption is that vanilla-extract works on top of standard typescript/javascript (i.e not extending any syntactic feature), so probably applying this plugin for child compiler is not necessary.

Testing Strategy:

The reproduction fix is verified with same patch mrm007/remix-vite-vanilla-repro#2

Copy link

changeset-bot bot commented Nov 13, 2023

⚠️ No Changeset found

Latest commit: 3acd903

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hi-ogawa
Copy link
Contributor Author

Closed in favor of #7994

@hi-ogawa hi-ogawa closed this Nov 14, 2023
@hi-ogawa hi-ogawa deleted the fix-vite-skip-vanilla-extract-child-compiler branch November 14, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant