fix(remix-dev/vite): allow custom NODE_ENV for vite dev

[hi-ogawa]

Closes: #7918

This can be achieved by

• set skipEnvCheck: true for react-refresh/babel plugin, and
• update LiveReload to check viteCommand = "serve" instead of NODE_ENV = "development"

I initially thought the error "React Refresh Babel transform should only be enabled in development environment." only manifests when remix plugin is (unintentionally) loaded on vitest, but I found that this can also happen, for example, when doing NODE_ENV=test vite dev.
So, I think it makes sense to disable this check (and also allow HMR) for other NODE_ENV as well since it looks like too-opinionated restriction. Also remix itself applies this transform only on "serve" command, so such warning is irrelevant.

Also note that this is yet-another compatibility with @vitejs/plugin-react, which also uses skipEnvCheck: true:
https://github.com/vitejs/vite-plugin-react/blob/38b3cece51644f3d4ba78e2352717b5077bd4637/packages/plugin-react/src/index.ts#L196-L199

Testing Strategy:

I didn't add a test case since it felt a little redundant. But, to verify the behavior, I locally checked vite-dev-test.ts still passes after manually modifying NODE_ENV: "test" here:

remix/integration/vite-dev-test.ts

Lines 205 to 209 in 25181c6

	devProc = spawn(nodeBin, [viteBin, "dev"], {
	cwd: projectDir,
	env: process.env,
	stdio: "pipe",
	});

- env: process.env,
+ env: { ...process.env, NODE_ENV: "test" },

[changeset-bot]

🦋 Changeset detected

Latest commit: 0269019

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages

Name	Type
@remix-run/dev	Patch
create-remix	Patch
remix	Patch
@remix-run/architect	Patch
@remix-run/cloudflare	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
@remix-run/css-bundle	Patch
@remix-run/deno	Patch
@remix-run/eslint-config	Patch
@remix-run/express	Patch
@remix-run/node	Patch
@remix-run/react	Patch
@remix-run/serve	Patch
@remix-run/server-runtime	Patch
@remix-run/testing	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[markdalgleish]

Thanks for the PR!

[github-actions]

🤖 Hello there,

We just published version 2.3.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 2.3.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!