-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle multiple "Set-Cookie" headers in unstable_vitePlugin dev #7843
Conversation
🦋 Changeset detectedLatest commit: e202cd7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @nickprinsloo, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Thanks for the PR! I noticed the same issue has already fixed in solid-start's implementation in the time since we used their adapter as our initial starting point. I've updated your PR to use theirs instead to keep the two implementations closer. I've also made the ordering more explicit in the test. |
Great, makes sense. Thanks for taking a look. |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Closes: #7837
Testing Strategy:
Added additional test to the existing integration test for the Vite Node adapter.