Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable Vite: dedupe and optimize react deps #7725

Merged
merged 2 commits into from
Oct 22, 2023

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Oct 21, 2023

Currently, we require userland config to do this. We should just do it for the user automatically when the Vite plugin for Remix is used. Then the userland vite config can be simplified by omitting the optimizeDeps and resolve entries.

See vite-plugin-react for a reference implementation.

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2023

⚠️ No Changeset found

Latest commit: 98919f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pcattori pcattori force-pushed the pedro/vite-dedupe-and-optimize-react-deps branch from 57c20ae to ecdd369 Compare October 22, 2023 04:19
@pcattori pcattori marked this pull request as ready for review October 22, 2023 04:19
@pcattori pcattori merged commit 9e30e56 into dev Oct 22, 2023
9 checks passed
@pcattori pcattori deleted the pedro/vite-dedupe-and-optimize-react-deps branch October 22, 2023 04:42
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Oct 22, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.2.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.2.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant