Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

place route updates in manifest.routes, not manifest itself #7681

Merged
merged 1 commit into from
Oct 16, 2023
Merged

place route updates in manifest.routes, not manifest itself #7681

merged 1 commit into from
Oct 16, 2023

Conversation

pcattori
Copy link
Contributor

fixes useloaderdata destructuring when adding a loader to a route during HMR

TypeError: Cannot destructure property 'blah' of `useLoaderData(...)` as it is null.

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 95fed6a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pcattori pcattori marked this pull request as ready for review October 16, 2023 21:40
@pcattori @brophdawg11
place route updates in manifest.routes, not manifest itself
95fed6a 
fixes useloaderdata destructuring when adding a loader to a route during HMR

```
TypeError: Cannot destructure property 'blah' of `useLoaderData(...)` as it is null.
```

Co-authored-by: Matt Brophy <[email protected]>
@pcattori pcattori force-pushed the pedro/vite-fix-manifest-updates branch from 25128e3 to 95fed6a Compare October 16, 2023 21:40
@pcattori pcattori merged commit 03e00c3 into dev Oct 16, 2023
@pcattori pcattori deleted the pedro/vite-fix-manifest-updates branch October 16, 2023 22:00
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Oct 16, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.2.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.2.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdalgleish markdalgleish markdalgleish approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcattori @markdalgleish