Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(create-remix): allow dots in nested folder names in GitHub repo shorthand #7277

Merged
merged 2 commits into from
Aug 29, 2023
Merged

feat(create-remix): allow dots in nested folder names in GitHub repo shorthand #7277

merged 2 commits into from
Aug 29, 2023

Conversation

brophdawg11
Copy link
Contributor

Allow github repo shorthand notation to contain dots:

npx create-remix --template remix-run/examples/socket.io

Closes remix-run/examples#267

@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 673889a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

brophdawg11
brophdawg11 commented Aug 28, 2023
View reviewed changes
packages/create-remix/__tests__/create-remix-test.ts
args: [
projectDir,
"--template",
"fake-remix-tester/nested-dir/folder.with.dots",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the nested-dir-repo.tar.gz file and copied the existing stack/ directory to folder.with-dots/ for this test

brophdawg11
brophdawg11 commented Aug 28, 2023
View reviewed changes
packages/create-remix/copy-template.ts
Comment on lines +387 to +389
if (isUrl(value)) {
return false;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we'd get collisions for URLs with file extensions - but it felt safe to ensure that we short circuit exit on non-RULs when looking for a shorthand

brophdawg11
brophdawg11 commented Aug 28, 2023
View reviewed changes
packages/create-remix/index.ts
Comment on lines -320 to +322
let collisions = files1.filter((f) => files2.includes(f));
let collisions = files1
.filter((f) => files2.includes(f))
.sort((a, b) => a.localeCompare(b));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into a test failure due to these files being printed to the console in a different order, so sort the collisions list for stability

@brophdawg11 brophdawg11 mentioned this pull request Aug 28, 2023
Closed
@MichaelDeBoey MichaelDeBoey changed the title Allow dots in nested folder names in github repo shorthand feat(create-remix): allow dots in nested folder names in GitHub repo shorthand Aug 28, 2023
@brophdawg11 brophdawg11 changed the base branch from dev to release-next August 29, 2023 14:12
@brophdawg11 brophdawg11 changed the base branch from release-next to dev August 29, 2023 14:13
@brophdawg11 brophdawg11 changed the base branch from dev to release-next August 29, 2023 14:18
@brophdawg11 brophdawg11 merged commit d5e82be into release-next Aug 29, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/create-remix-folder-dots branch August 29, 2023 17:48
@github-actions github-actions bot mentioned this pull request Aug 29, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-5b5bb9b-20230830 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.3 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-a9edc94-20230831 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.4 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-6c0310c-20230901 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

🤖 Hello there,

We just published version 2.0.0-pre.6 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-9288516-20230902 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

🤖 Hello there,

We just published version 2.0.0-pre.7 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

🤖 Hello there,

We just published version 2.0.0-pre.7 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-481f73e-20230906 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

🤖 Hello there,

We just published version 2.0.0-pre.8 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-1a57073-20230907 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

🤖 Hello there,

We just published version 2.0.0-pre.9 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-1fac238-20230908 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.10 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-3646f91-20230914 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@maxrchung maxrchung mentioned this pull request Mar 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@markdalgleish markdalgleish markdalgleish approved these changes

Assignees

@markdalgleish markdalgleish

Labels
CLA Signed package:create-remix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brophdawg11 @markdalgleish @MichaelDeBoey