Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(remix-server-runtime): remove polyfill references #7205

Merged
merged 1 commit into from
Aug 28, 2023
Merged

test(remix-server-runtime): remove polyfill references #7205

merged 1 commit into from
Aug 28, 2023
+13 −19

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Aug 21, 2023 •
edited
Loading

Just like we did in @jacob-ebey's #7230
We can do this because we call installGlobals for our tests

remix/packages/remix-server-runtime/__tests__/setup.ts

Line 2 in 6b6bb39

installGlobals();

@MichaelDeBoey MichaelDeBoey added package:server-runtime v2 Issues related to v2 apis labels Aug 21, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1d15cf2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey force-pushed the try-to-avoid-web-polyfills-in-server-runtime branch 2 times, most recently from 6229f62 to ddf23c1 Compare August 21, 2023 23:12
@MichaelDeBoey MichaelDeBoey changed the title refactor(remix-server-runtime): try to avoid @remix-run/web-* usage refactor(remix-server-runtime): use native Fetch API Aug 22, 2023
@MichaelDeBoey MichaelDeBoey force-pushed the try-to-avoid-web-polyfills-in-server-runtime branch 3 times, most recently from bf46ce4 to 689cbd7 Compare August 22, 2023 01:59
@brophdawg11 brophdawg11 removed their request for review August 22, 2023 14:59
@MichaelDeBoey MichaelDeBoey changed the title refactor(remix-server-runtime): use native Fetch API test(remix-server-runtime): remove polyfill references Aug 28, 2023
@MichaelDeBoey MichaelDeBoey force-pushed the try-to-avoid-web-polyfills-in-server-runtime branch from 689cbd7 to f3e8959 Compare August 28, 2023 01:00
@MichaelDeBoey MichaelDeBoey mentioned this pull request Aug 28, 2023
Merged
@MichaelDeBoey MichaelDeBoey force-pushed the try-to-avoid-web-polyfills-in-server-runtime branch from f3e8959 to 1d15cf2 Compare August 28, 2023 16:50
@MichaelDeBoey MichaelDeBoey merged commit 0c888c1 into remix-run:dev Aug 28, 2023
@MichaelDeBoey MichaelDeBoey deleted the try-to-avoid-web-polyfills-in-server-runtime branch August 28, 2023 17:01
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

This was referenced Aug 29, 2023
Merged
Merged
@KarelVerschraegen KarelVerschraegen mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brophdawg11 brophdawg11 brophdawg11 approved these changes

@markdalgleish markdalgleish Awaiting requested review from markdalgleish

@pcattori pcattori Awaiting requested review from pcattori

@jacob-ebey jacob-ebey Awaiting requested review from jacob-ebey

Assignees
No one assigned
Labels
CLA Signed package:server-runtime v2 Issues related to v2 apis
Projects
No open projects
v2
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @brophdawg11