-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: decouple css-bundle from dev #6982
fix: decouple css-bundle from dev #6982
Conversation
🦋 Changeset detectedLatest commit: a887bb8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
This PR makes it so that the contents of the
@remix-run/css-bundle
package are entirely managed by the Remix compiler rather than injectingcssBundleHref
value into the package contents after reading them from disk—which we only did to support HMR whencssBundleHref
used to be on the manifest but this is no longer the case. This ensures that there are no runtime errors when upgrading@remix-run/dev
without upgrading@remix-run/css-bundle
.I wanted to get this change in for v2 so that this is the case for all v2.x releases.