feat!(remix-react,remix-server-runtime): remove deprecated properties from HtmlLinkDescriptor, LinkDescriptor & PrefetchPageDescriptor types

[MichaelDeBoey]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: d4269e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@remix-run/react	Major
@remix-run/server-runtime	Major
@remix-run/testing	Major
@remix-run/cloudflare	Major
@remix-run/deno	Major
@remix-run/dev	Major
@remix-run/node	Major
@remix-run/cloudflare-pages	Major
@remix-run/cloudflare-workers	Major
create-remix	Major
@remix-run/css-bundle	Major
@remix-run/architect	Major
@remix-run/express	Major
@remix-run/netlify	Major
@remix-run/vercel	Major
@remix-run/serve	Major
remix	Major
@remix-run/eslint-config	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[chaance]

Hey @MichaelDeBoey, I think we should actually keep these in place for now. We have no plans to drop support for React 17, and I don't want the console yelling at folks who are following older type defs. Gonna go ahead and close this for now!

[MichaelDeBoey]

@chaance This is not dropping React 17 support, it is only dropping the possible use of these props.

I still made sure that React 17 is supported, so I think we should re-open this PR

remix/packages/remix-react/components.tsx

Lines 379 to 384 in f4bb542

	// In React 17, <link imageSrcSet> and <link imageSizes> will warn
	// because the DOM attributes aren't recognized, so users need to pass
	// them in all lowercase to forward the attributes to the node without a
	// warning. Normalize so that either property can be used in Remix.
	let imageSizesKey = "useId" in React ? "imageSizesKey" : "imagesizes";
	let imageSrcSetKey = "useId" in React ? "imageSrcSet" : "imagesrcset";

remix/packages/remix-react/components.tsx

Lines 400 to 401 in f4bb542

	[imageSizesKey]: imageSizes,
	[imageSrcSetKey]: imageSrcSet,

[brophdawg11]

I added some filters for console.log assertions in #5706 prior to merging to avoid false negatives. Once dev is merged out to v2 again we should rebase this and remove those filters in this PR

[MichaelDeBoey]

@brophdawg11 The extra changes you mentioned are now removed as well in this PR

Oops - looks like a few integration tests are busted

[brophdawg11]

@MichaelDeBoey Do you mind checking out the failed integration tests? Maybe they're using the syntax we're dropping support for in v2? Once those are fixed up I think we can get this merged 👍

[MichaelDeBoey]

@brophdawg11 It was my own mistake, I used "imageSizesKey" as the attribute instead of "imageSizes" 😅🙈😓

Tests should pass now 👍