Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: dog food @remix-run/testing #5529

Closed
wants to merge 6 commits into from
Closed

test: dog food @remix-run/testing #5529

wants to merge 6 commits into from

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Feb 21, 2023 •
edited
Loading

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: a60db72

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcansh mcansh linked an issue Feb 21, 2023 that may be closed by this pull request
🗺 dog food @remix-run/testing #5528
Closed
@mcansh mcansh force-pushed the logan/dogfood-testing branch 2 times, most recently from a5c827c to 43eab5c Compare February 27, 2023 18:44
mcansh
mcansh commented Feb 27, 2023
View reviewed changes
new-integration/setupAfterEnv.ts Outdated
import { installGlobals } from "@remix-run/node";
import "@testing-library/jest-dom/extend-expect";

export let jestTimeout = process.platform === "win32" ? 20_000 : 10_000;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: try removing this, copied it from another package and extended with extend-expect and installGlobals

@mcansh mcansh force-pushed the logan/dogfood-testing branch from 53da1db to 40bb0e7 Compare February 27, 2023 19:25
@mcansh
fix: pkg scripts
a60db72 
Signed-off-by: Logan McAnsh <[email protected]>
@github-actions github-actions bot added the needs-response We need a response from the original author about this issue/PR label Apr 28, 2023
@remix-run remix-run deleted a comment from github-actions bot Apr 30, 2023
@machour machour removed the needs-response We need a response from the original author about this issue/PR label Apr 30, 2023
@brophdawg11 brophdawg11 self-assigned this Jul 10, 2023
@brophdawg11 brophdawg11 mentioned this pull request Aug 16, 2023
Merged
@brophdawg11
Copy link
Contributor

Superseded by #7186

@MichaelDeBoey MichaelDeBoey deleted the logan/dogfood-testing branch August 21, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brophdawg11 brophdawg11

Labels
CLA Signed package:testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🗺 dog food @remix-run/testing
3 participants
@mcansh @brophdawg11 @machour