Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev): update tailwind config detection to also look for cjs #5358

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Feb 3, 2023

when using type: "module" in package.json you need to make any commonjs files have the .cjs extension however require.resolve won't look for them 🙈

note: tailwindcss doesn't currently support mjs so that extension is intentionally missing.

Signed-off-by: Logan McAnsh [email protected]

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2023

🦋 Changeset detected

Latest commit: bcd2bd6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
remix Patch
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mcansh mcansh changed the title fix: update tailwind config detection to also look for cjs fix(remix-dev): update tailwind config detection to also look for cjs Feb 3, 2023
@mcansh mcansh merged commit ff22f78 into dev Feb 7, 2023
@mcansh mcansh deleted the logan/tailwind-find-cjs branch February 7, 2023 19:00
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Feb 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-ff22f78-20230208 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed package:dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants