Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(remix-dev/cli): fix broken stacks link #3874

Merged
merged 1 commit into from
Aug 4, 2022
Merged

chore(remix-dev/cli): fix broken stacks link #3874

merged 1 commit into from
Aug 4, 2022

Conversation

julio-lemos
Copy link
Contributor

Found an issue with the CLI when on the stack selection. The link includes ) in the link when clicking the link from the terminal. This resulted in a 404 page.

@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2022

⚠️ No Changeset found

Latest commit: 49e89ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 29, 2022

Hi @julio-lemos,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@MichaelDeBoey MichaelDeBoey changed the title fix: CLI link for stacks was broken chore(remix-dev/cli): fix broken stacks link Aug 4, 2022
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 2c93fbf into remix-run:dev Aug 4, 2022
@julio-lemos julio-lemos deleted the patch-1 branch August 12, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants