Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-react): support undefined unions as optional keys in UseDataFunctionReturn type #3766

Merged
merged 4 commits into from
Jul 27, 2022

Conversation

itsMapleLeaf
Copy link
Contributor

Previously, objects with possibly undefined values became required. This PR makes it so they become optional instead, and preserves other behavior around undefined.

  • Old: { a: number | undefined } -> { a: number }
  • New: { a: number | undefined } -> { a?: number }
  • Docs
  • Tests

Testing Strategy:

Added a new test to packages/remix-react/__tests__/hook-types-test.tsx, and ensured present type tests still pass.

@changeset-bot
Copy link

changeset-bot bot commented Jul 16, 2022

🦋 Changeset detected

Latest commit: 26fe8c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
remix Patch
@remix-run/react Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/cloudflare Patch
@remix-run/node Patch
@remix-run/deno Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/vercel Patch
create-remix Patch
@remix-run/architect Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 16, 2022

Hi @itsMapleLeaf,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 16, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@itsMapleLeaf itsMapleLeaf changed the base branch from main to dev July 16, 2022 17:18
@itsMapleLeaf itsMapleLeaf force-pushed the undefined-optionals branch from 34f02f2 to 70d3c9b Compare July 16, 2022 17:19
@MichaelDeBoey MichaelDeBoey changed the title fix: support undefined unions as optional keys in loader data fix(remix-react): support undefined unions as optional keys in UseDataFunctionReturn type Jul 16, 2022
packages/remix-react/components.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants