-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix-react): support undefined unions as optional keys in UseDataFunctionReturn
type
#3766
Conversation
🦋 Changeset detectedLatest commit: 26fe8c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @itsMapleLeaf, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
34f02f2
to
70d3c9b
Compare
UseDataFunctionReturn
type
Previously, objects with possibly undefined values became required. This PR makes it so they become optional instead, and preserves other behavior around undefined.
{ a: number | undefined }
->{ a: number }
{ a: number | undefined }
->{ a?: number }
Testing Strategy:
Added a new test to
packages/remix-react/__tests__/hook-types-test.tsx
, and ensured present type tests still pass.