Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds theme-ui example project #3637

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Conversation

guatedude2
Copy link
Contributor

This PR provides a Theme-UI Remix example with support for SSR.

Closes: #3636

  • Docs
  • Tests

Testing Strategy:

Tested example locally

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 1, 2022

Hi @guatedude2,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 1, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@guatedude2
Copy link
Contributor Author

system-ui/theme-ui#2231

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me. Only thing is the funny newline character in the README.

examples/theme-ui/README.md Show resolved Hide resolved
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're good 👍

examples/theme-ui/README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants