chore(integration): improve build failure output in tests #3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
requested changes
Jun 24, 2022
Display the actual contents of stderr when things fail. Leaving the commented-out debug stuff above it, as that can be useful for seeing what's happening when things don't fail.
jenseng
force-pushed
the
integration-fail-on-build-errors
branch
from
1adb43e to
8e930aa
Compare
|
✅ Done! |
MichaelDeBoey
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display the actual contents of stderr when things fail. I preserved the commented-out debug stuff, as that can be useful for seeing what's happening when things don't fail.
Testing Strategy: