fix(remix-react): detect index route from manifest in useFormAction

[penspinner]

The useFormAction hook detects the file ID ending in "/index" to determine whether or not to return a form action with the ?index search param. This holds true in Remix's default route convention. However, in the case where the consumer defines custom routes, this may not hold true anymore.

---

Testing Strategy:

I'm using the Remix Flat Routes flat-folders convention in my project.

Let's say I have a route _auth.dashboard.index/_routes.tsx. That's considered to be an index route in the flat-folders convention. However, rendering a <Form> in that route results in a form with the action "/dashboard" while the action should be "/dashboard?index".

[MichaelDeBoey]

@penspinner Could you please also add a test for this change?

[changeset-bot]

⚠️ No Changeset found

Latest commit: cec2d4a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[kiliman]

Awesome work @penspinner. BTW: I did fix remix flat routes to work around this issue. I append /index to all the index route ids so Remix works properly. Once this PR lands, I'll be able to remove the hack. Thanks!

[MichaelDeBoey]

Hi @penspinner!

Are you still interested in getting this one merged?

If so, please rebase onto latest dev & resolve conflicts

[penspinner]

@MichaelDeBoey This seems to have been fixed in React Router. Gonna close this.