Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templates/vercel): add index.js.map to .gitignore #2761

Closed
wants to merge 2 commits into from

Conversation

nshki
Copy link

@nshki nshki commented Apr 12, 2022

First off, thank you all for this lovely project. Remix gives me the same excitement as when I first discovered HTML back in the 2000s.

This is something I noticed as I was upgrading a Remix v1.2.3 project to v1.3.5—Git kept telling me it detected some untracked files in /api and after a closer look, /api/index.js.map was the new file.

This change is to ignore /api/index.js.map in addition to /api/index.js and prevent /api from getting checked into repositories.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Apr 12, 2022

Hi @nshki,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Apr 12, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@machour
Copy link
Collaborator

machour commented Apr 13, 2022

Hi @nshki and thank you for your contribution.
Can you rebase your changes against the dev branch ?

@nshki nshki force-pushed the update-vercel-gitignore branch from 217e5ec to 10f5134 Compare April 13, 2022 15:06
@nshki nshki changed the base branch from main to dev April 13, 2022 15:07
@nshki
Copy link
Author

nshki commented Apr 13, 2022

@machour Done!

@Gerhut
Copy link

Gerhut commented Apr 18, 2022

Just found this PR and can we do just /api/index.js.map since I was doing some vercel tricks in the api directory? 😄

@nshki
Copy link
Author

nshki commented Apr 18, 2022

Just found this PR and can we do just /api/index.js.map since I was doing some vercel tricks in the api directory? 😄

I think that makes sense! @machour would love your take on it before I make that change.

@machour
Copy link
Collaborator

machour commented Apr 18, 2022

Could hardly tell, never used vercel 😅

@nshki
Copy link
Author

nshki commented Apr 18, 2022

@Gerhut to make sure I'm understanding you correctly, you were saying you want just the addition of /api/index.js.map in this PR, correct? And not suggesting that we only have /api/index.js.map in the ignored files?

@MichaelDeBoey MichaelDeBoey changed the title Add * to /api/index.js in Vercel's .gitignore fix(templates/vercel): add index.js.map to .gitignore Jun 13, 2022
nshki added 2 commits June 13, 2022 12:36
This is to also ignore `/api/index.js.map` and prevent `/api` from
getting checked into repositories.
@MichaelDeBoey MichaelDeBoey force-pushed the update-vercel-gitignore branch from 10f5134 to f7cfc14 Compare June 13, 2022 10:36
@MichaelDeBoey
Copy link
Member

Closing this as we already merged #3216 to fix this.

@MichaelDeBoey MichaelDeBoey added the duplicate This issue or pull request already exists label Jun 13, 2022
@nshki nshki deleted the update-vercel-gitignore branch June 13, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed duplicate This issue or pull request already exists template:vercel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants