-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(templates/vercel): add index.js.map
to .gitignore
#2761
Conversation
Hi @nshki, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Hi @nshki and thank you for your contribution. |
217e5ec
to
10f5134
Compare
@machour Done! |
Just found this PR and can we do just |
I think that makes sense! @machour would love your take on it before I make that change. |
Could hardly tell, never used vercel 😅 |
@Gerhut to make sure I'm understanding you correctly, you were saying you want just the addition of |
/api/index.js
in Vercel's .gitignoreindex.js.map
to .gitignore
This is to also ignore `/api/index.js.map` and prevent `/api` from getting checked into repositories.
10f5134
to
f7cfc14
Compare
Closing this as we already merged #3216 to fix this. |
First off, thank you all for this lovely project. Remix gives me the same excitement as when I first discovered HTML back in the 2000s.
This is something I noticed as I was upgrading a Remix v1.2.3 project to v1.3.5—Git kept telling me it detected some untracked files in
/api
and after a closer look,/api/index.js.map
was the new file.This change is to ignore
/api/index.js.map
in addition to/api/index.js
and prevent/api
from getting checked into repositories.