Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: prerelease test infrastructure #1408

Merged
merged 118 commits into from
Jan 14, 2022
Merged

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Jan 7, 2022

This PR adds automated testing of prereleases to Netlify, Vercel, Fly, Cloudflare Pages, Cloudflare Workers, and AWS (via architect).

first and foremost, {target}-prerelease-deployment.test.yml GitHub Action for each target that runs a node script to create a new project on the given target with the name remix-{target}-{sha} and runs a very basic cypress assertion on the dev server and the deployed url.

mcansh added 30 commits January 5, 2022 13:36
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
@mcansh mcansh requested a review from kentcdodds January 13, 2022 18:49
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is brilliant! Very well done @mcansh 👏

Just one thing I think either you missed or I misunderstand.

scripts/deployment-test/arc.mjs Show resolved Hide resolved
mcansh added 15 commits January 14, 2022 14:43
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Just two quick things.

.github/workflows/cf-pages-prerelease-deployment.test.yml Outdated Show resolved Hide resolved
scripts/deployment-test/fly-dockerfile Outdated Show resolved Hide resolved
@mcansh mcansh requested a review from kentcdodds January 14, 2022 23:03
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome work. Great job Logan. Have a good weekend!

@kentcdodds kentcdodds merged commit c8dc234 into dev Jan 14, 2022
@kentcdodds kentcdodds deleted the logan/rem-656-netlify-prerelease-test branch January 14, 2022 23:43
@cmd-johnson
Copy link
Contributor

cmd-johnson commented Jan 20, 2022

Hi there!
I'm currently working on a PR for getting yarn PnP to work with Remix (#1316). Today I rebased my changes to the current dev branch and the create-remix command no longer works. The prompts all show, but after creating the project directory, the program just exits. Using git bisect, I pinned this down to changes made in this PR. Commit c8dc234 to be precise.

I'm not quite sure what's happening here.
The program runs fine until

await fse.mkdir(projectDir);
after which it just exits without giving any reason whatsoever.

@cmd-johnson
Copy link
Contributor

Oooooh, I see what's happening
There's an await missing here:

@kentcdodds
Copy link
Member

Thanks for letting us know! We've fixed that now :) Sorry for the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants