build(fly): build before deploy

[CanRau]

includes the changes of KCD from #930

from: https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#type
from: https://www.conventionalcommits.org/en/v1.0.0/
from: https://cheatography.com/albelop/cheat-sheets/conventional-commits/

from: https://gist.github.com/lisawolderiksen/a7b99d94c92c6671181611be1641c733

[remix-cla-bot]

Hi @CanRau,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[kentcdodds]

This PR needs to be made to dev ratchet than the main branch. Not sure I think we should build before the deploy. What do we do in the other templates? Either way it should be the same with all the templates.

[CanRau]

Yea sorry I was kinda distracted by making my first PR via gh-cli and forgot to add my reasoning

And for the branch, there isn't a way to move this right? So I close this one and make a new one on the other branch right?

[kentcdodds]

That would be an easier way, yeah

[CanRau]

Alright, before opening the new one I thought it might be better to check in, as we already have this discussion, sharing my thinking.

So, to me it was quite confusing, that running npm run deploy wouldn't update my website 😳 I know it's kinda my fault not properly checking what the npm scripts are doing, but there's also no mention of ever running npm run build in the Readme.

Therefore I propose either adding it to the readme or running it automatically before deploy.

Personally I prefer the latter as I don't have much reason to deploy without building, but there might be other preferences I guess.
As for what other templates are doing, the Workers one builds already before deploying and others don't require builds or deploys, as far as I can tell.

So closing this one, awaiting feedback on if and how to make a new PR to dev

[kentcdodds]

Thanks for the feedback. I agree we should make a change. I just want to make sure we're the same in every template. Could you open an issue about it so it can be discussed and a decision can be made?