Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox doesn't follow es module imports on transitions? (I think?) #7

Closed
ryanflorence opened this issue Oct 28, 2020 · 6 comments
Closed

Firefox doesn't follow es module imports on transitions? (I think?) #7

ryanflorence opened this issue Oct 28, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@ryanflorence
Copy link
Member

ryanflorence commented Oct 28, 2020 •
edited
Loading

Need to investigate further and will add more details, but just clicking around the docs page in firefox doesn't work. It imports the entries but then it doesn't follow the imports from there.

This is pretty low priority right now for us. We'll be creating a "nomodule" bundle with System.js for browser that don't support es modules, when we're in the think of things there we'll also investigate and fix this.

Until then however, if you have any ideas on why firefox won't follow the imports, let us know :)
@matthova matthova mentioned this issue Oct 29, 2020
Closed
@matthova
Copy link
Contributor

Thought I was going crazy. Bummer, but good to know it's not just me.

@ryanflorence ryanflorence added the bug Something isn't working label Oct 30, 2020
@matthova
Copy link
Contributor

matthova commented Nov 8, 2020

Any word on this? Guessing it'd be some sort of webpack tweak?

@matthova
Copy link
Contributor

Wondering if there's a way I can help with this issue. For me no Firefox support would be a blocker from releasing.

(totally understand it's alpha right now, would love to help out where it makes sense)

@mjackson mjackson mentioned this issue Jan 11, 2021
Closed
@JNaftali
Copy link
Contributor

Did y'all change something? Clicking around the docs site works for me now (and it def did not before).

@hsiaoa
Copy link

hsiaoa commented Jan 23, 2021

+1
reporting our remix site is working on Firefox as well
we are still on 0.8, so perhaps Firefox's last update fixed it?

@ryanflorence
Copy link
Member Author

Looks like Firefox fixed their bug--whatever it was!

mjackson added a commit that referenced this issue May 1, 2021
@mjackson
Lots of caching improvements
2755930 
- Add Cache-Control to /__remix_manifest responses
- Don't call /__remix_data for routes that don't have data loaders
- Remove location-based browser data cache, use built-in caching instead
- Automatically reload the page when we detect the build has changed
- Add `useBeforeUnload` hook for saving state immediately before reload
- Add `json` and `redirect` helpers to `@remix-run/loader`

Fixes #3
Fixes #4
Fixes #7
Fixes #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ryanflorence @JNaftali @matthova @hsiaoa